Skip to content

add kube_deployment_status_replicas_terminating and kube_replicaset_status_terminating_replicas metrics #2708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

add kube_deployment_status_replicas_terminating and kube_replicaset_status_terminating_replicas metrics #2708

wants to merge 2 commits into from
+86 −32

Conversation

atiratree
Copy link
Member

@atiratree atiratree commented Jul 21, 2025 •
edited
Loading

What this PR does / why we need it:

This is needed to support the kubernetes/enhancements#3973 observability and to promote DeploymentReplicaSetTerminatingReplicas to Beta kubernetes/kubernetes#133087

Requires: #2664

How does this change affect the cardinality of KSM: increases

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 21, 2025
@k8s-ci-robot k8s-ci-robot requested review from logicalhan and mrueg July 21, 2025 07:32
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: atiratree
Once this PR has been reviewed and has the lgtm label, please assign dgrisonnet for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 21, 2025
@atiratree atiratree mentioned this pull request Jul 21, 2025
Open
dependabot bot and others added 2 commits July 21, 2025 11:03
@dependabot @atiratree
build(deps): Bump the k8s-dependencies group with 5 updates
31f1aa7 
Bumps the k8s-dependencies group with 5 updates:

| Package | From | To |
| --- | --- | --- |
| [k8s.io/api](https://github.com/kubernetes/api) | `0.32.3` | `0.33.0` |
| [k8s.io/apimachinery](https://github.com/kubernetes/apimachinery) | `0.32.3` | `0.33.0` |
| [k8s.io/client-go](https://github.com/kubernetes/client-go) | `0.32.3` | `0.33.0` |
| [k8s.io/component-base](https://github.com/kubernetes/component-base) | `0.32.3` | `0.33.0` |
| [k8s.io/sample-controller](https://github.com/kubernetes/sample-controller) | `0.32.3` | `0.33.0` |


Updates `k8s.io/api` from 0.32.3 to 0.33.0
- [Commits](kubernetes/api@v0.32.3...v0.33.0)

Updates `k8s.io/apimachinery` from 0.32.3 to 0.33.0
- [Commits](kubernetes/apimachinery@v0.32.3...v0.33.0)

Updates `k8s.io/client-go` from 0.32.3 to 0.33.0
- [Changelog](https://github.com/kubernetes/client-go/blob/master/CHANGELOG.md)
- [Commits](kubernetes/client-go@v0.32.3...v0.33.0)

Updates `k8s.io/component-base` from 0.32.3 to 0.33.0
- [Commits](kubernetes/component-base@v0.32.3...v0.33.0)

Updates `k8s.io/sample-controller` from 0.32.3 to 0.33.0
- [Commits](kubernetes/sample-controller@v0.32.3...v0.33.0)

---
updated-dependencies:
- dependency-name: k8s.io/api
  dependency-version: 0.33.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: k8s-dependencies
- dependency-name: k8s.io/apimachinery
  dependency-version: 0.33.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: k8s-dependencies
- dependency-name: k8s.io/client-go
  dependency-version: 0.33.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: k8s-dependencies
- dependency-name: k8s.io/component-base
  dependency-version: 0.33.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: k8s-dependencies
- dependency-name: k8s.io/sample-controller
  dependency-version: 0.33.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: k8s-dependencies
...

Signed-off-by: dependabot[bot] <[email protected]>
@atiratree
add kube_deployment_status_replicas_terminating and kube_replicaset_s…
0785f33 
…tatus_terminating_replicas metrics
@atiratree atiratree force-pushed the terminating-replicas-rs-deploy branch from 6eb6e66 to 0785f33 Compare July 21, 2025 09:03
@atiratree atiratree mentioned this pull request Jul 21, 2025
Open
4 tasks
@richabanker
Copy link
Contributor

/triage accepted
/cc @rexagod

@k8s-ci-robot k8s-ci-robot requested a review from rexagod July 24, 2025 17:01
@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jul 24, 2025
@CatherineF-dev
Copy link
Contributor

Error: ../../../go/pkg/mod/k8s.io/[email protected]/pkg/cel/environment/base.go:53:30: undefined: featuregate.DefaultComponentGlobalsRegistry
Error: ../../../go/pkg/mod/k8s.io/[email protected]/pkg/cel/environment/base.go:53:94: undefined: featuregate.DefaultKubeComponent
Error: ../../../go/pkg/mod/k8s.io/[email protected]/pkg/cel/environment/base.go:55:30: undefined: utilversion.DefaultKubeEffectiveVersion

Could you upgrade k8s version in a separate pull request?

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 7, 2025
@k8s-ci-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@logicalhan logicalhan Awaiting requested review from logicalhan

@mrueg mrueg Awaiting requested review from mrueg

@rexagod rexagod Awaiting requested review from rexagod

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@atiratree @k8s-ci-robot @richabanker @CatherineF-dev