Skip to content

feat: add kube_deployment_status_replicas_terminating and kube_replicaset_status_terminating_replicas metrics #2708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: add kube_deployment_status_replicas_terminating and kube_replicaset_status_terminating_replicas metrics #2708

wants to merge 1 commit into from
+54 −0

Conversation

atiratree
Copy link
Member

@atiratree atiratree commented Jul 21, 2025 •
edited
Loading

What this PR does / why we need it:

This is needed to support the kubernetes/enhancements#3973 observability and to promote DeploymentReplicaSetTerminatingReplicas to Beta kubernetes/kubernetes#133087

How does this change affect the cardinality of KSM: increases

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 21, 2025
@k8s-ci-robot k8s-ci-robot requested review from logicalhan and mrueg July 21, 2025 07:32
@k8s-ci-robot k8s-ci-robot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 21, 2025
@atiratree atiratree mentioned this pull request Jul 21, 2025
Closed
@atiratree atiratree force-pushed the terminating-replicas-rs-deploy branch from 6eb6e66 to 0785f33 Compare July 21, 2025 09:03
@atiratree atiratree mentioned this pull request Jul 21, 2025
Open
4 tasks
@richabanker
Copy link
Contributor

/triage accepted
/cc @rexagod

@k8s-ci-robot k8s-ci-robot requested a review from rexagod July 24, 2025 17:01
@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jul 24, 2025
@CatherineF-dev
Copy link
Contributor

Error: ../../../go/pkg/mod/k8s.io/[email protected]/pkg/cel/environment/base.go:53:30: undefined: featuregate.DefaultComponentGlobalsRegistry
Error: ../../../go/pkg/mod/k8s.io/[email protected]/pkg/cel/environment/base.go:53:94: undefined: featuregate.DefaultKubeComponent
Error: ../../../go/pkg/mod/k8s.io/[email protected]/pkg/cel/environment/base.go:55:30: undefined: utilversion.DefaultKubeEffectiveVersion

Could you upgrade k8s version in a separate pull request?

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 7, 2025
@github-project-automation github-project-automation bot moved this to Needs Triage in SIG Instrumentation Aug 26, 2025
@rexagod rexagod self-assigned this Aug 27, 2025
@rexagod rexagod moved this from Needs Triage to Needs Review in SIG Instrumentation Aug 27, 2025
@atiratree atiratree force-pushed the terminating-replicas-rs-deploy branch from 0785f33 to ae96403 Compare September 25, 2025 12:18
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 25, 2025
@atiratree atiratree changed the title add kube_deployment_status_replicas_terminating and kube_replicaset_status_terminating_replicas metrics feat: add kube_deployment_status_replicas_terminating and kube_replicaset_status_terminating_replicas metrics Sep 25, 2025
@atiratree atiratree force-pushed the terminating-replicas-rs-deploy branch from ae96403 to 643c9e9 Compare September 25, 2025 12:35
@atiratree
Copy link
Member Author

I removed the go.mod bump requirement and rebased the PR.

Should be ready for a review @CatherineF-dev @richabanker @rexagod

@soltysh for SIG Apps

soltysh
soltysh approved these changes Sep 29, 2025
View reviewed changes
Copy link

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm from sig-apps pov

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: atiratree, soltysh
Once this PR has been reviewed and has the lgtm label, please ask for approval from rexagod. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@logicalhan logicalhan Awaiting requested review from logicalhan

@mrueg mrueg Awaiting requested review from mrueg

@rexagod rexagod Awaiting requested review from rexagod

1 more reviewer

@soltysh soltysh soltysh approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@rexagod rexagod

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG Instrumentation
Status: Needs Review (PR) or Response (Issue)
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@atiratree @richabanker @CatherineF-dev @k8s-ci-robot @soltysh @rexagod